-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: allow stylelint@^16.0.0 in peerDependencies #25
Conversation
Upgrade stylelint devDependency to 16, but removed support for Node.js less than 18.12.0 and refactored their code to use ESM so the other changes were necessary and [described in the stylelint migration guide][1]. [1]: https://github.com/stylelint/stylelint/blob/16.0.0/docs/migration-guide/to-16.md
Thank you for this! This is a big help. Were you able to verify this works in v15 as well as v16 now? If not, I will test this out locally as well to ensure we have support for both the pre- and post- v16 updates. |
Thank you for doing this! It seems good to me, so once we get the CI to pass we will be good to go 👏 |
Looks like there is an issue still with @DaveLak Do you have any ideas? |
Looks like it's a Jest error right now.
|
@DaveLak @Israel-Laguan I am closing this PR and deferring to the more robust PR here: #28 This is where the package is updated to properly align with Stylelint 16. Trying to work out a small issue with my husly/commit-lint setup, but the tests for v16 are now passing. |
Thanks, @yuschick! Sorry I missed that and was slow to respond (holiday season and all 😅) |
Honestly, for the best. I shouldn't have even been looking at this over the holidays. But yeah, all good, and thank you for the help in moving this forward 🙌 |
📒 Description
This upgrades the
stylelint
devDependency to version 16, but they removed support for Node.js versions less than 18.12.0 (because Node.js 14 and 16 have reached end-of-life) and refactored their code to use ESM so the other changes were necessary and described in the stylelint migration guide.🚀 Changes
peerDependencies
"engines"
field inpackage.json
to"node": ">=18.12.0"
🔐 Closes
#24
⛳️ Testing
npx ls-engines@latest
to verify the dependency graph's stated "engines" criteria is met.ls-engines Output
npm run test
before and after changes.