Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Accidental Hover False Positive Within :not() Selectors #31

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix Accidental Hover False Positive Within :not() Selectors #31

merged 2 commits into from
Jan 11, 2024

Conversation

yuschick
Copy link
Owner

@yuschick yuschick commented Jan 11, 2024 •
edited
Loading

📒 Description

  • checks for :hover selectors inside of :not() selectors to prevent the accidental hover rule from reporting

🚀 Changes

  • adds regexp check for :not(:hover) selectors
  • adds tests for different :not() situations
  • increments version to 1.0.1

🔐 Closes

#30

⛳️ Testing

  • ran npm run test to ensure all tests pass
image

@yuschick yuschick merged commit 63b5b8d into main Jan 11, 2024
1 check passed
@yuschick yuschick deleted the fix/accidental-hover-not-selector branch January 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yuschick