Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxy volumes #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix proxy volumes #113

wants to merge 1 commit into from

Conversation

Elbandi
Copy link
Contributor

@Elbandi Elbandi commented Oct 21, 2024 •
edited
Loading

What this PR does / why we need it:

When zabbixAgent has extraVolumes values, but zabbixProxy has not, the generated zabbix proxy manifest is invalid:

  imagePullSecrets:
    - configMap:
        name: userparameters
      name: userparameters-volume

(volume: yaml name is missing)

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeciopires aeciopires Awaiting requested review from aeciopires aeciopires is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Elbandi