Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes to #175
As mentioned by @unixmonkey, there's no official build for ubuntu24.04 on https://wkhtmltopdf.org/downloads.html.
We could use the same binary used for
ubuntu_22.04
;This pull request includes updates to support Ubuntu 24.04 in the Docker setup and associated tests. The most important changes include adding a new Dockerfile for Ubuntu 24.04 and updating the test suite to include a test for Ubuntu 24.04.
Docker support for Ubuntu 24.04:
.docker/Dockerfile-ubuntu_24.04
: Added a new Dockerfile for Ubuntu 24.04, setting up the environment and installing necessary packages.Test suite updates:
test/test_with_docker.rb
: Added a new test methodtest_with_ubuntu_24
to test the setup on Ubuntu 24.04.