Replace shortid to nanoid #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhen0409
approved these changes
Nov 5, 2017
|
@jhen0409 thanks, it was fast :). Should we release it in new patch version? :) |
|
@ai sorry about missing this and the long delay! I have just published We're moving this repository into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think of replacing
shortidtonanoid(without big changes for users). Benefits:shortidis not maintained anymore (and issue tracker has many important issues). I tried to took maintenance, but found that I can’t fixshortidwith keeping API.shortidhas problem with random generator (issue) and ID uniformity (issue).nanoiduse hardware random generator and has special uniformity tests (docs).nanoidis just 179 bytes.shortidis 2 times bigger (about 0.5 KB).nanoidis 10x times faster thanshortid.@zalmoxisus what do you think?