Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw error if node version out-dated #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jatZama
Copy link
Member

@jatZama jatZama commented Jun 30, 2024

This might be useful to avoid many silently failing tests if Node version is less than 20. Wdyt?

@immortal-tofu
Copy link
Collaborator

Not a big fan of preinstall script for this usage, it could create new issue for some projects. I think it's ok to just use "engines". Developer can use tools to verify engines for their package if they want to.

@jatZama
Copy link
Member Author

jatZama commented Jun 30, 2024

ok, should i remove this hook from fhevm and hardhat-template as well then?

@immortal-tofu
Copy link
Collaborator

Yes, especially for fhevm because fhevm is a Solidity library and we don't care if people are using node 18 in this case. AFAIK, preinstall is used in both situations: when you do npm install locally in the repository and when you do npm install fhevm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants