Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 7.2 and 7.3 #51

Open
wants to merge 13 commits into
base: 3.x
Choose a base branch
from
Open

Drop support for PHP 7.2 and 7.3 #51

wants to merge 13 commits into from

Conversation

zaporylie
Copy link
Owner

As part of this PR support for php 7.2 and 7.3 is dropped. Also, PHP 8.1 and 8.2 are added to the test matrix. Given the base branch for this PR is 3.x I am also planning to add support for typed properties.

@zaporylie zaporylie changed the base branch from 3.x to 2.x July 25, 2023 14:29
@zaporylie zaporylie changed the base branch from 2.x to 3.x July 25, 2023 14:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch coverage: 72.46% and project coverage change: -0.77% ⚠️

Comparison is base (af5d46e) 60.05% compared to head (c3a7023) 59.29%.
Report is 1 commits behind head on 3.x.

❗ Current head c3a7023 differs from pull request most recent head 42a54e2. Consider uploading reports for the commit 42a54e2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x      #51      +/-   ##
============================================
- Coverage     60.05%   59.29%   -0.77%     
- Complexity      444      446       +2     
============================================
  Files            80       80              
  Lines          1432     1442      +10     
============================================
- Hits            860      855       -5     
- Misses          572      587      +15     
Flag Coverage Δ
unittests 59.29% <72.46%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Api/UserInfo.php 0.00% <0.00%> (ø)
src/Resource/IdempotencyKeyFactory.php 0.00% <0.00%> (ø)
src/Resource/RecurringPayment/CancelCharge.php 0.00% <0.00%> (ø)
src/Resource/RecurringPayment/CaptureCharge.php 0.00% <0.00%> (ø)
src/Resource/RecurringPayment/CreateAgreement.php 0.00% <0.00%> (ø)
src/Resource/RecurringPayment/CreateCharge.php 0.00% <0.00%> (ø)
src/Resource/RecurringPayment/GetAgreement.php 0.00% <ø> (ø)
src/Resource/RecurringPayment/GetAgreements.php 0.00% <ø> (ø)
src/Resource/RecurringPayment/GetCharge.php 0.00% <ø> (ø)
src/Resource/RecurringPayment/GetCharges.php 0.00% <ø> (ø)
... and 22 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaporylie
Copy link
Owner Author

@CodiumAI-Agent /describe

@CodiumAI-Agent
Copy link

Preparing pr description...

@zaporylie
Copy link
Owner Author

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Analysis

  • 🎯 Main theme: Drop support for PHP 7.2 and 7.3 and add support for PHP 8.1 and 8.2
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: Yes
  • Focused PR: Yes, the PR is focused as it clearly states its purpose in the title and description. All the changes in the PR are relevant to the theme of dropping support for older PHP versions and adding support for newer ones.
  • 🔒 Security concerns: No, the PR does not introduce any apparent security concerns. The changes are mostly related to updating PHP version support and do not involve any security-sensitive operations.

PR Feedback

  • 💡 General PR suggestions: The PR is well-structured and follows good coding practices. It is commendable that the contributor has added relevant tests for the changes made. However, it would be beneficial to include in the PR description the reasons for dropping support for PHP 7.2 and 7.3, and how this might affect existing users of the library. Also, it would be helpful to include any potential breaking changes that might occur due to this update.

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve: Suggest improvements to the code in the PR.
/ask <QUESTION>: Pose a question about the PR.

To edit any configuration parameter from 'configuration.toml', add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."

@zaporylie
Copy link
Owner Author

@CodiumAI-Agent /describe

@CodiumAI-Agent
Copy link

Preparing pr description...

Copy link

@truls1502 truls1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants