Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarr V3 metadata fixes #248

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

LDeakin
Copy link

@LDeakin LDeakin commented Oct 6, 2024

This fixes several problems with zarr.json metadata that I noticed when implementing a chunk manifest storage transformer.

  • Chunk key encoding should be v2 with . separator to match manifest.json
    • the chunk-manifest-json storage transformer should not need to be aware of the chunk key encoding
  • Fix the fill value defaulting to NaN for integer arrays
  • Encode non-finite float fill values as strings
  • Default bytes codec "endian" to "little"
    • This needs to be addressed properly at some point
  • Fix tests using null fill value or nan fill value for integer data type

@LDeakin
Copy link
Author

LDeakin commented Oct 6, 2024

Type-checking failures seem unrelated

@LDeakin LDeakin marked this pull request as ready for review October 6, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant