Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icechunk Support #256

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Conversation

mpiannucci
Copy link

@mpiannucci mpiannucci commented Oct 15, 2024

Adds the ability to write to an Icechunk store. Co developed with @TomNicholas.

See earth-mover/VirtualiZarr#1 for more information (ported from that branch)

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

@norlandrhagen
Copy link
Collaborator

@mpiannucci happy to help out on the icechunk integration effort. Are there bits you think that might good to split off and tackle? CI, docs, testing etc?

@TomNicholas
Copy link
Member

Docs could definitely be added in a separate PR. Also the whole problem of saving non-virtual references to icechunk.

IIUC the issues preventing this PR from going in are more to do with upstream dependencies (Zarr, kerchunk).

@mpiannucci
Copy link
Author

Correct. I am going to be working on kerchunk, but that also has some zarr upstream dependencies. Things are moving forward but will take a little time

@norlandrhagen
Copy link
Collaborator

Totally makes sense! I'll hold off a bit until some things stabilize. Thanks again for all the work on this @mpiannucci, it'll be really cool to be able to virtualize to icechunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency enhancement New feature or request references formats Storing byte range info on disk zarr-python Relevant to zarr-python upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants