Change occurrences of % and format() to f-strings

[DimitriPapadopoulos]

The rationale is that f-strings are faster.

TODO:

• Add unit tests and/or doctests in docstrings
• Add docstrings and API docs for any new/modified user-facing classes and functions
• New/modified features documented in docs/tutorial.rst
• Changes documented in docs/release.rst
• GitHub Actions have all passed
• Test coverage is 100% (Codecov passes)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (720bea6) 99.99% compared to head (46989fd) 99.99%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files          38       38           
  Lines       14574    14574           
=======================================
  Hits        14573    14573           
  Misses          1        1           

Files	Coverage Δ
zarr/_storage/absstore.py	100.00% <100.00%> (ø)
zarr/_storage/store.py	100.00% <100.00%> (ø)
zarr/_storage/v3.py	100.00% <ø> (ø)
zarr/convenience.py	100.00% <100.00%> (ø)
zarr/core.py	100.00% <100.00%> (ø)
zarr/creation.py	100.00% <100.00%> (ø)
zarr/errors.py	100.00% <100.00%> (ø)
zarr/hierarchy.py	100.00% <100.00%> (ø)
zarr/indexing.py	100.00% <100.00%> (ø)
zarr/meta.py	100.00% <100.00%> (ø)
... and 6 more

[d-v-b]

I will fix these conflicts, and then I think this should be good to go in.

[d-v-b]

@rabernat any objection to getting this in to the release?

[DimitriPapadopoulos]

This string was cut in half, looks like a left-over from #1459.

[DimitriPapadopoulos]

Perhaps log("{}".format(arg)) should actually be changed to log("%s", arg), so that string formatting interpolation is not executed if logging is not enabled.

• Some developers argue that deferring that string interpolation to the logging function, after checking whether logging is enabled, is a perceptible speed win if logging is disabled. See Pylint's logging-fstring-interpolation / W1203.
• Other developers argue that the speed win is hardly perceptible because the cost of a function call is much higher, while the speed win of f-strings if logging is enabled is more perceptible. See Discourage logging f-strings due to security considerations python/cpython#90358.

See also:

• https://docs.python.org/3/howto/logging.html#optimization

[joshmoore]

Conflicts fixed. @DimitriPapadopoulos: please note it looks like 46989fd#diff-35a6b5d683684d4a73baf73ec18e5a438a738b98e3138b494834bca5add5ba4bR1399 was missing an f?

[DimitriPapadopoulos]

Conflicts fixed. @DimitriPapadopoulos: please note it looks like 46989fd#diff-35a6b5d683684d4a73baf73ec18e5a438a738b98e3138b494834bca5add5ba4bR1399 was missing an f?

Indeed, sorry about that. Because pyupgrade cannot be restricted to a specific rule and misses some cases, it wasn't easy to automate such changes. I guess ruff is a better alternative because you can --select specific rules and --fix issues.