New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce ruff/Perflint rules (PERF) #2372

Merged

jhamman merged 2 commits into zarr-developers:main from DimitriPapadopoulos:PERF

Oct 17, 2024

+19 −27

Contributor

DimitriPapadopoulos commented Oct 15, 2024 •

edited

Loading

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

DimitriPapadopoulos force-pushed the PERF branch 2 times, most recently from 9702613 to aa37d7c Compare

October 15, 2024 13:34

jhamman approved these changes

View reviewed changes

Member

jhamman commented Oct 15, 2024

there's a merge conflict here but it otherwise this looks good.

DimitriPapadopoulos added 2 commits

October 16, 2024 08:19


          Apply ruff/Perflint rule PERF401

c3728f3

PERF401 Use a list comprehension to create a transformed list


          Enforce ruff/Perflint rules (PERF)

4c054e1

DimitriPapadopoulos force-pushed the PERF branch from aa37d7c to 4c054e1 Compare

October 16, 2024 06:21

jhamman merged commit 85c9b5f into zarr-developers:main

22 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet