Enforce ruff/refurb rules (FURB)

pyproject.toml

@@ -207,30 +207,33 @@ extend-exclude = [
 
 [tool.ruff.lint]
 extend-select = [
-    "ANN", # flake8-annotations
-    "B",   # flake8-bugbear
-    "C4",  # flake8-comprehensions
-    "FLY", # flynt
-    "I",   # isort
-    "ISC", # flake8-implicit-str-concat
-    "PGH", # pygrep-hooks
-    "PT",  # flake8-pytest-style
-    "PYI", # flake8-pyi
-    "RSE", # flake8-raise
-    "RET", # flake8-return
+    "ANN",  # flake8-annotations
+    "B",    # flake8-bugbear
+    "C4",   # flake8-comprehensions
+    "FLY",  # flynt
+    "FURB", # refurb
+    "I",    # isort
+    "ISC",  # flake8-implicit-str-concat
+    "PGH",  # pygrep-hooks
+    "PT",   # flake8-pytest-style
+    "PYI",  # flake8-pyi
+    "RSE",  # flake8-raise
+    "RET",  # flake8-return
     "RUF",
-    "TCH", # flake8-type-checking
-    "TRY", # tryceratops
-    "UP",  # pyupgrade
+    "TCH",  # flake8-type-checking
+    "TRY",  # tryceratops
+    "UP",   # pyupgrade
 ]
 ignore = [
     "ANN003",
     "ANN101",
     "ANN102",
     "ANN401",
-    "PT004",  # deprecated
-    "PT011",  # TODO: apply this rule
-    "PT012",  # TODO: apply this rule
+    "FURB118", # TODO: apply this rule
+    "FURB140", # TODO: apply this rule
+    "PT004",   # deprecated
+    "PT011",   # TODO: apply this rule
+    "PT012",   # TODO: apply this rule
     "PYI013",
     "RET505",
     "RET506",

src/zarr/core/indexing.py

@@ -1129,7 +1129,7 @@ def __init__(
         chunks_multi_index_broadcast = np.broadcast_arrays(*chunks_multi_index)
 
         # remember shape of selection, because we will flatten indices for processing
-        sel_shape = selection_broadcast[0].shape if selection_broadcast[0].shape else (1,)
+        sel_shape = selection_broadcast[0].shape or (1,)
 
         # flatten selection
         selection_broadcast = tuple(dim_sel.reshape(-1) for dim_sel in selection_broadcast)
@@ -1150,7 +1150,7 @@ def __init__(
         else:
             sel_sort = None
 
-        shape = selection_broadcast[0].shape if selection_broadcast[0].shape else (1,)
+        shape = selection_broadcast[0].shape or (1,)
 
         # precompute number of selected items for each chunk
         chunk_nitems = np.bincount(chunks_raveled_indices, minlength=nchunks)

src/zarr/storage/memory.py

@@ -156,8 +156,7 @@ async def list_prefix(self, prefix: str) -> AsyncGenerator[str, None]:
 
     async def list_dir(self, prefix: str) -> AsyncGenerator[str, None]:
         # docstring inherited
-        if prefix.endswith("/"):
-            prefix = prefix[:-1]
+        prefix = prefix.removesuffix("/")
 
         if prefix == "":
             keys_unique = {k.split("/")[0] for k in self._store_dict}

src/zarr/storage/zip.py

@@ -245,8 +245,7 @@ async def list_prefix(self, prefix: str) -> AsyncGenerator[str, None]:
 
     async def list_dir(self, prefix: str) -> AsyncGenerator[str, None]:
         # docstring inherited
-        if prefix.endswith("/"):
-            prefix = prefix[:-1]
+        prefix = prefix.removesuffix("/")
 
         keys = self._zf.namelist()
         seen = set()