Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce ruff/flake8-pyi rule PYI013 #2389

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Enforce ruff/flake8-pyi rule PYI013 #2389

merged 1 commit into from
Oct 17, 2024
+0 −7

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 16, 2024 •
edited
Loading

PYI013 Non-empty class body must not contain ...

Note that documentation is enough to fill the class body.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@DimitriPapadopoulos
Enforce ruff/flake8-pyi rule PYI013
6f085cc 
PYI013 Non-empty class body must not contain `...`

Note that documentation is enough to fill the class body.
@jhamman jhamman merged commit 28389fe into zarr-developers:main Oct 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @jhamman