Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test that stores empty file #2560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxrjones
Copy link
Member

This test parameterization was causing failures in #1661 because it would create a file with no bytes stored, which would lead to failures when trying to read specific bytes. @jhamman recommended removing the test and opening a PR for input from @d-v-b.

@d-v-b
Copy link
Contributor

d-v-b commented Dec 15, 2024

I don't think we use the "write no bytes" feature anywhere in zarr, but to me it's a bit suspicious that our stores pass this test but a different store does not -- that suggests some fundamental differences between the stores that I would like to understand better before we weaken the tests

@maxrjones
Copy link
Member Author

I don't think we use the "write no bytes" feature anywhere in zarr

Do you think a chunk could compress to zero bytes if it's only zeros or fill values depending on the compressor?

but to me it's a bit suspicious that our stores pass this test but a different store does not -- that suggests some fundamental differences between the stores that I would like to understand better before we weaken the tests

That makes sense. There are two cases related to a chunk with zero bytes that are tested here:

  1. Test get for an entire persisted chunk with zero bytes - this should return an empty byte string and does for all the stores
  2. Test get with a byte range specified for a persisted chunk with zero bytes - fsspec seems to return an empty byte string while obstore errors with Generic LocalFileSystem error: Requested range was invalid. Which do you think is more appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants