Extract incrementalmerkletree::testing module to a separate incrementalmerkletree-testing crate.
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
incrementalmerketree-testing
branch
2 times, most recently
from
b23a5e6
to
d3db03f
Compare
str4d
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Partial review as of d3db03f (I'm still checking the large move).
If it turns out that the workspace change does require downstreams to raise MSRV, I would prefer that we explicitly raise MSRV in its own commit instead of implicitly doing.
I'd mildly perfer 1.64 instead of 1.70 for this PR (as that is the only necessary bump; it could be raised again in a subsequent PR as new features are needed).
str4d
reviewed
Sep 25, 2024
This requires us to upgrade our MSRV to 1.64
…talmerkletree-testing` crate.
nuttycom
force-pushed
the
incrementalmerketree-testing
branch
from
d3db03f
to
f6a5ae4
Compare
str4d
approved these changes
Sep 25, 2024
nuttycom
force-pushed
the
incrementalmerketree-testing
branch
from
f6a5ae4
to
03a32d5
Compare
nuttycom
force-pushed
the
incrementalmerketree-testing
branch
from
03a32d5
to
d663a8f
Compare
str4d
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow us to continue to move
incrementalmerkletreeandshardtreedevelopment forward without having to continue to maintainbridgetreecompatibility withincrementalmerkletree::testingafter the nextincrementalmerkletreerelease.