Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shardtree: Significantly rework handling of checkpoint depths and truncation operations. #115

Merged
merged 3 commits into from
Sep 27, 2024
Merged

shardtree: Significantly rework handling of checkpoint depths and truncation operations. #115

merged 3 commits into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. incrementalmerkletree-testing: Always rewind to a checkpoint. 

    The previous semantics of the `rewind` operation would remove the last
checkpoint, if any, but would not further modify the tree. However,
these semantics are error prone - if you rewind to a checkpoint, you are
not able to rewind to the same checkpoint again; also, in practice, it
doesn't make sense to shift the location of a checkpoint in the note
commitment tree. This change alters `rewind` to (a) take an explicit
checkpoint depth, with depth `0` meaning that any state added since the
last checkpoint should be discarded, and (b) only allow a rewind
operation to succeed if a checkpoint actually exists at the specified
depth.
    @nuttycom
    nuttycom committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    05f23d9 View commit details
    Browse the repository at this point in the history

  2. shardtree: Rework rewind & checkpoint depth handling.

    @nuttycom
    nuttycom committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9a77e51 View commit details
    Browse the repository at this point in the history

  3. Apply documentation suggestions from code review 

    Co-authored-by: Jack Grigg <[email protected]>
    @nuttycom @str4d
    nuttycom and str4d committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3f59900 View commit details
    Browse the repository at this point in the history