Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylelint extension #1732

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

florian-sanders
Copy link

@florian-sanders florian-sanders commented Nov 29, 2024

Fixes #1648

  • This PR adds an extension to wrap stylelint LSP,
  • Stylelint is used to lint CSS content in files that support it (CSS, SCSS, JS, etc.),
  • The VSCode Stylelint Extension is fairly popular with more than 2,595,360 installs,
  • The LSP server comes from the stylelint/vscode-stylelint project but there are few things to note:
    • the GitHub repository contains both the LSP server and the VSCode extension code,
    • the LSP server is not entirely decoupled from VSCode extension code but it does work on it's own,
    • neither the LSP Server or the VSCode are published as npm packages,
    • the source code needs to be built (TypeScript project) & bundled to be used,
  • I had to fork the original repository so that I could:

About the fork & npm package

I don't mind maintaining the fork & npm package but I'd definitely be okay to make it less about me and more about Zed or the community.
I chose to publish the LSP package in the @florian-sanders scope on npm just because I wanted to make it clear that it was not officially published by the Stylelint team but I'm open to other options.

For what it's worth, I have created an issue on the source repository to ask:

  • if it was okay to fork (license allows it but just in case),
  • if they are still planning on decoupling the server & extension code,
  • if they plan on publishing the server as a standalone package.

You can follow the discussions here: stylelint/vscode-stylelint#623
For now nobody has answered.

@cla-bot cla-bot bot added the cla-signed label Nov 29, 2024
@florian-sanders florian-sanders marked this pull request as draft November 29, 2024 18:51
@florian-sanders florian-sanders marked this pull request as ready for review November 29, 2024 19:11
@Mouvedia
Copy link

@ota-meshi @ybiquitous

@florian-sanders

This comment was marked as resolved.

@notpeter
Copy link
Member

Sorry, I have not yet had a chance to review (Stylelint is entirely new to me).

Zed does maintain some forks of upstream node projects and publish npm packages to go with. Depending on the reply upstream, that might be appropriate here too.

@florian-sanders
Copy link
Author

Thanks for rebasing, I should have done that before pinging you 👍

Zed does maintain some forks of upstream node projects and publish npm packages to go with. Depending on the reply upstream, that might be appropriate here too.

Perfect, I hope we get some answer from upstream, we'll see!

If I can be of any help, don't hesitate to ping me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stylelint
3 participants