-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add move language v0.0.1 #1799
Add move language v0.0.1 #1799
Conversation
@Tzal3x It was found through actual testing that there are some problems with some expressions in the repository. Only after the actual modifications can the grammar display be satisfied. And a pull request (PR) has been submitted to your repository to fix some issues. Please help review it. Thank you. |
@lispking what are the issues? I am not able to install the extension using the modifications you submitted. The PR I submitted is functional, so this can be merged. We can make a patch to the extension (if needed) when the exact problem is highlighted. Thanks! 🚀 |
Alternatively, I'll submit the patch to your repository. That would be more appropriate. @Tzal3x |
Just saw your update on the PR @lispking. Nice work, merged! ✅ Let's hope zed maintainers will accept this one soon to reach the community. |
Update gitmodules for move language Such a name is more in line with the official naming standards. When I was installing it on my computer, if I used "move-zed-extension", it couldn't show that the installation was successful, and I couldn't find any plugin with the name "move" either. However, after changing the name to "move", it could be installed successfully
Hey, @notpeter respectively asking for your review. 🙏 |
Excite you were able to get this working! I know this is a big ask, but would be willing to re-write history for your repo to remove the 60-odd MB of binaries from /target which were accidentally included in-tree prior to Tzal3x/move-zed-extension@d49f35f? I know it's a PITA, but I would prefer not require another 60MB of disk storage on everyone who recursively checks out the extensions repo. I'd recommend something like git-filter-repo. Here's an example git-filter-repo usage instructions we use extracting extensions from the zed repo. The zed repo submodule is by far the worst offender (192MB) but we are working to remove that entirely in favor of individual extension repos. |
That would be a huge PITA indeed, and since this is the very first version of the extension I just squashed all commits. From now on each patch/version will have its own commit and the issue with |
I bumped the submodule commit on your branch.
A lot has happened since
|
This comment was marked as resolved.
This comment was marked as resolved.
I'm not sure I understand the error of the CI, and I don't have access re-running it to experiment with it. Mind lending a hand here? 😬 |
That did it! Thanks! And congrats on your first Zed Extension! |
Closes #717
Here is an example of the LSP working by hovering over the
use sui::dynamic_field as df;