Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update placeholder text with key bindings to focus context panel and navigate history #19447

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nathansobo
Copy link
Contributor

Hopefully, this will help people understand how easy it is to add context to an inline transformation.

CleanShot 2024-10-18 at 22 41 00@2x

@as-cii @maxdeviant @rtfeldman could somebody update this to display the actual correct key bindings and ship it. I have them hard coded for now.

Release Notes:

  • Updated placeholder text with key bindings to focus context panel and navigate history.

Hopefully, this will help people understand how easy it is to add context to an inline transformation.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 19, 2024
@rtfeldman rtfeldman self-assigned this Oct 21, 2024
@rtfeldman
Copy link
Contributor

I updated this to use the active keybinding for toggling the panel, which turns out to default to ⌘? rather than ⇧⌘? (because on a US Mac keyboard ? is shift-/ so cmd-shift-? would be like cmd-shift-shift-/ or something).

Our function to display keybindings currently renders it as Command-? instead of ⌘? - I could see arguments for and against changing that, although if we do change it, I imagine we'd want to change it everywhere and not just for inline assist.

Screenshot 2024-10-21 at 11 16 27 AM

It doesn't look like we have customizable keybindings for the history, so I left those hardcoded.

@rtfeldman
Copy link
Contributor

@nathansobo if you're cool with how this looks, I can ship it. Otherwise I can look into the implications of changing the Mac keybindings (in general) to display with symbols instead of words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants