-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ollama: Allow specifying a bearer token #19493
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Gustavo Noronha Silva.
|
Hi, thanks for this PR! The bearer token shouldn't be stored in settings as it's a secret. We support reading API keys from the environment (e.g. ANTHROPIC_API_KEY, OPENAI_API_KEY) or keeping credentials in the platform specific keychain (search for For example: zed/crates/language_model/src/provider/anthropic.rs Lines 107 to 126 in 92c29be
Unlike the other providers, this key would be optional (e.g. local ollama requires no auth), but we'd want to support reading |
That makes sense, thank you for the quick feedback! I have started on that path. It is quite a bit more code. I got the UI to render, most of the code structure is in place, I believe, but it is still not working and the UI could use a little bit more love. I will try to get it finished during the week, may need to wait for the weekend, though. |
Closes #19491
Release Notes: