-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new way to deploy and configure workers #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add templates to worker.yaml, so it can be configured from values file New configuration options: jobtype, loglevel, resources Make worker extensible so we can define many more workers, via easily adding new maps (values) for specific workers.
Missing capabilities seem to be related to the camunda-platform helm chart change, I reported it here |
Replace defaults with conditional branches, to avoid to maintain several defaults, in values, templates and benchmark apps. Conditions allow toe also not set values, like resources
In order to be backward compatible with previous deployments introduce a new workers values, instead of overwriting the worker
Zelldon
force-pushed
the
ck-configure-apps
branch
from
September 2, 2024 10:21
cec7d60
to
dcf2b7e
Compare
Zelldon
changed the title
Configure Worker and make them more extensible
Introduce new way to deploy and configure workers
Sep 2, 2024
npepinpe
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains
Introduce a new
workers
value into thevalues.yaml
, next to the oldworker
value. This is to keep backward compatibility.The
worker.yaml
has been copied and extended with templates, such that it can be better configured from the values file. New configuration options are: jobtype, completionDelay, payloadPath, loglevel, resourcesFurthermore, the workers are now more extensible, such that we can define many more workers, by easily adding new maps (values) for specific workers.
This will be useful for the realistic benchmarks where we want to deploy many different workers, see also slack channel
Example
Having the worker values in our
values.yaml
can produce the following deployments: