Introduce SaaS support for benchmarks #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow benchmarks to configure and run against SaaS environment
Secret that stores configured credential details for benchmark applications
Zelldon
force-pushed
the
ck-saas-support
branch
from
deb6c8e
to
9e618b4
Compare
npepinpe
approved these changes
Sep 20, 2024
Comment on lines
+55
to
+58
| - name: ZEEBE_ADDRESS | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: {{ include "zeebe-benchmark.credentials-name" $ }} |
There was a problem hiding this comment.
❓ Is the address really a secret? 🤷
There was a problem hiding this comment.
I guess it doesn't matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously it was not possible to use the benchmark helm charts to run benchmarks against our SaaS offering. The only option was to use the starter, worker resource definitions in the mono-repo here
Solution
This PR introduces the option to configure credentials either direct via values or reference an existing secret, which might be deployed similar as this.
When the new Saas option is enabled workers and starter are configured to use the related credentials, and connect to a SaaS cluster via TLS.
With this we are able to support benchmarks against SaaS more easily, with the full power and configuration options the Benchmark helm chart supports.