Log more response errors #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only logged (not sure but current assumption) BAD_REQUEST returned from saas
Zelldon
force-pushed
the
ck-fix-errors
branch
from
eb68c81
to
0895e7a
Compare
megglos
approved these changes
Sep 18, 2023
cloud-client/src/main/java/io/zeebe/clustertestbench/cloud/filter/BadResponseFilter.java
Outdated
Show resolved
Hide resolved
cloud-client/src/main/java/io/zeebe/clustertestbench/cloud/filter/BadResponseFilter.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/zeebe/clustertestbench/handler/FailedServiceShouldFailResponseTest.java
Outdated
Show resolved
Hide resolved
This test was more to verify how the behavior is currently when an exception or error response is sent, but doesn't bring much value since it is already tested in the dependencies
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Sep 19, 2023
891: Log more response errors r=Zelldon a=Zelldon Previously we only logged (not sure but current assumption) BAD_REQUEST returned from SAAS Related to #889 Co-authored-by: Christopher Zell <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into main (it was a non-fast-forward update). It will be automatically retried. |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only logged (not sure but current assumption) BAD_REQUEST returned from SAAS
Related to #889