First contribution #132
Open
First contribution #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed jxon and the code that uses it
added ability to skip 127
custom 127 encoding
added a check for NaN
|
@zemuldo Need help with the review?? |
@mcfriend99 Please go ahead. I also plan to have a look this weekend. |
|
@jlaustill Please update the change to enable the GitHub actions matrix when you can. I plan to review the PR this weekend. |
|
@zemuldo Sorry, I didn't notice the contribution readme :) I'm working with iso packets from Fiserve, and they do a LOT of non standard stuff. So I have this library wrapped by another class that does a tons more to the iso after parsing. Keep that in mind as you review :) |
|
Please update the branch you have for tests to run. |
zemuldo
requested changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some error handling around the ISO format for healthcare and the ability to leave the 127 field un-expanded and encoded in a customer encoding.