Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msaadsiddiqui patch 1 #137

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Conversation

msaadsiddiqui
Copy link
Contributor

@msaadsiddiqui msaadsiddiqui commented Sep 19, 2023

Allow custom bitmap encoding for 127.1

@msaadsiddiqui
Copy link
Contributor Author

Test case passed now, can you now please merge it . Thanks @zemuldo

@zemuldo zemuldo merged commit 54b6589 into zemuldo:main Sep 25, 2023
5 checks passed
zemuldo pushed a commit that referenced this pull request Sep 25, 2023
* minor changes to 127.1 ,if bitmap is customized

* unpack 127 for bitmap ascii

* Update assemble127_extensions.ts

---------

Co-authored-by: TPSONLINE\Saad.Siddiqui <[email protected]>
@msaadsiddiqui
Copy link
Contributor Author

Hi @zemuldo can you tell me when you will proceed with new release for npm ? so i can install for this fix from npm

@zemuldo
Copy link
Owner

zemuldo commented Sep 25, 2023

Yes. I will ping you as soon as I do. What version do you currently have? The current major version is quite behind. I am planning to release the new major version written in typescript. For now this will be in the next beta.
@msaadsiddiqui

@msaadsiddiqui
Copy link
Contributor Author

@zemuldo Hi I am on 2.6.7 right now , I think that's the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants