Bugfix/fix inconsistent tabs #2379
Conversation
dosubot
bot
added
size:M
|
Any chance of a fast animation like this PR instead of the instant snap back? |
This is up to @mauro-balades, I just fixed an issue. |
| @@ -7,6 +7,10 @@ | |||
| height: 100%; | |||
| } | |||
|
|
|||
| #TabsToolbar { | |||
| padding: var(--zen-toolbox-padding); | |||
There was a problem hiding this comment.
Not sure about this, itll make the tabs be un-aligned
There was a problem hiding this comment.
It actually aligns all tabs and makes sure they all share common padding. Otherwise every tab must have its margin set, and they were not consistent between different modes.
Also setting it as --zen-toolbox-padding will allow additional consistency.
Then only difference is between expandable & non-expandable as the top border adds 1px padding.
See:
| @@ -300,7 +299,6 @@ | |||
| box-shadow: 0 0 1px 1px rgba(0, 0, 0, 0.15) !important; | |||
| } | |||
| } | |||
| margin-inline: var(--tab-block-margin); | |||
There was a problem hiding this comment.
This is necessary for the shadows to appear
There was a problem hiding this comment.
Shadows are still there. The issue with this margin being here is the inconsistency.
See:
I can change it so all tabs (collapsed & expanded) have this margin applied.
|
Mostly fixed in recent updates. |
Fixed issues with jumping icons & inconsistent tab layout.
Now all vertical tab layouts use common padding for
TabsToolbar, consistent with the browser element separation.Note:
Two issues were not fixed:
Before:
After: