[tbc-ge] Convert transaction time to local timezone #734
Conversation
| // This causes a problem if the user is in a different timezone | ||
| // That is also not a 100% correct solution, | ||
| // but it should decrease the amount of operations with incorrect date | ||
| export function convertToLocalTimezone (data: number): number { |
There was a problem hiding this comment.
Please see the method parsePOSDateString and its usages in the project, it should (in theory) already correct the offset
There was a problem hiding this comment.
@Hermesiss Not exactly. It actually does quite the opposite.
The time in the POS string is always 12AM (midnight), and you set the timezone as UTC+4.
But ZM uses the user's phone timezone. So, for example, I did a bunch of transactions today (March 15th). All these transactions will have time as midnight of March 15th in UTC+4.
But if I am in UTC+2, then all these dates will be counted as March 14th, 22:00 in my local timezone, and ZM gonna save all today's transactions in the previous day (as 14th May).
TL;DR: if you are in a timezone to the west to UTC+4 you will have all transactions in the previous day.
There was a problem hiding this comment.
@dzhiriki Instead of manipulating the time zone directly if the bank doesn't specify the transaction time it's better to just set the time to 12:00+00:00. Or you can parse a date this way:
const dateInLocalTimezone = new Date('2024-03-18T12:54:32')
const dateInGeorgianTimezone = new Date('2024-03-18T12:54:32+04:00')There was a problem hiding this comment.
@skvav Could you elaborate on why do you think that solution is better?
For me, it is kinda the same. The only difference is that we shift to a fixed amount, instead of the user's timezone difference
There was a problem hiding this comment.
@skvav @dzhiriki
I have the same issue in Credo Bank Georgia. All transactions time saved in local Georgian time zone UTC+4:00. So when I create transaction outside Georgia even Credo Bank application shows transaction as it was made MY_TIME_ZONE - UTC+4:00 timezone earlier.
Looks like no timezone part in timestamps from bank responses.
No description provided.