-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr/module.yaml: add ble f/w blobs #20
Conversation
Configure zephyr/module.yaml to allow importation of BLE controller-only firmware required to work with zephyr bluetooth stack. Signed-off-by: Armando Visconti <[email protected]>
@@ -40,3 +40,6 @@ endif() | |||
|
|||
# STMEMSC - Hardware Abstraction Layer for ST sensor | |||
add_subdirectory_ifdef(CONFIG_HAS_STMEMSC sensor/stmemsc) | |||
|
|||
# Add BT firmware images upgrade support | |||
add_subdirectory_ifdef(CONFIG_BT ble_firmware) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a more specific option. BT could be enable on a nordic chip which uses this repo for sensors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure. I also now recalled that I have to separate the definitions in CMakeLists.txt for the images of different boards
4. This software or any part thereof, including modifications and/or derivative | ||
works of this software, must be used and execute solely and exclusively on or in | ||
combination with a microcontroller or microprocessor device manufactured by or | ||
for STMicroelectronics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the case. This limits use of this binary on ST(M32) HW and it should be moved to hal_stm32
|
||
#include <stdint.h> | ||
|
||
const uint8_t ble_fw_img[] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zephyr code can't be used in modules.
If required, this code should be hosted in zephyr repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember well I observed this method in hal/infineon. Can you take a look to zephyrproject/infineon/cat1cm0p/COMPONENT_CM0P_SLEEP/psoc6_cm0p_sleep.c
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zephyr code can't be used in modules. If required, this code should be hosted in zephyr repo
You mean maybe under zephyrproject/zephyr/modules
?
I see now that infineon is hosting there the bt stuff for their blobs... :(
type: img | ||
version: '1.0.0' | ||
license-path: zephyr/blobs/license.md | ||
url: https://github.com/STMicroelectronics/stsw-mkbox-bleco/raw/v1.0.0/img/steval-mkboxpro/DTM_SPI_WITH_UPDATER_CONTROLLER.bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this fw is specific to this board, it should be put in hal_stm32.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is
I'm going to close this PR, and open a new one on stm32 module. |
Configure zephyr/module.yaml to allow importation of BLE controller-only firmware required to work with zephyr bluetooth stack.
Substituted by:
zephyrproject-rtos/hal_stm32#217