[PoC][DNM] Add pip requirements for zephyr module #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
reviewed
Nov 2, 2024
zephyr/module.yml
Outdated
| @@ -2,3 +2,6 @@ name: nanopb | |||
| build: | |||
| cmake-ext: True | |||
| kconfig-ext: True | |||
| pip: | |||
There was a problem hiding this comment.
here I would call this packages, not pip, so
packages:
python:
....
This way we can extend this in the future to other things.
There was a problem hiding this comment.
I think it does make more sense to have the tool itself as a key, Both packages and requirements are specific to pip. It does not make sense to have it for poetry for example.
We can add another level to group more package management tools.
Update the zephyr/module.yml with pip requirements. Signed-off-by: Pieter De Gendt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the zephyr/module.yml with pip requirements.
NOTE: This PR is to demonstrate pip in zephyr module files.