project: Format and sort imports #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply isort on files in src/ Signed-off-by: Pieter De Gendt <[email protected]>
Apply isort on files in tests/ Signed-off-by: Pieter De Gendt <[email protected]>
Check for isort issues when running ruff check. Signed-off-by: Pieter De Gendt <[email protected]>
marc-hb
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
As discussed on Discord, I'm generally not a fan of these mass reformats because they break git cherry-pick/rebase/merge/revert/blame/... and they tend to do so repeatedly when the formatting tools gets upgraded or the west/ruff.config file gets "optimized". Moreover, this does not seem to add a lot of value.
HOWEVER this one looks small and harmful enough; a git conflict in imports should never be hard to fix.
| SelfUpdate, | ||
| Status, | ||
| Topdir, | ||
| Update, |
There was a problem hiding this comment.
1 per line is a significant waste of screen estate but no big deal...
There was a problem hiding this comment.
Splitting these long lines to help out a lot for git diffs though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply
isort --profile blackon files insrc/andtests/