Skip to content

Commit

Permalink
Fixes #24
Browse files Browse the repository at this point in the history
  • Loading branch information
@ciotlosm
ciotlosm committed Feb 12, 2021
1 parent 67a4a9f commit 6597d72
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion zigbee2mqtt-edge/config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"experimental": {},
"socat": {
"enabled": false,
"master": "pty,raw,echo=0,link=/dev/ttyZ2M,mode=777",
"master": "pty,raw,echo=0,link=/share/zigbee2mqtt/ttyZ2M,mode=777",
"slave": "tcp-listen:8485,keepalive,nodelay,reuseaddr,keepidle=1,keepintvl=1,keepcnt=5",
"options": "-d -d",
"log": false
Expand Down
2 changes: 1 addition & 1 deletion zigbee2mqtt/config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"experimental": {},
"socat": {
"enabled": false,
"master": "pty,raw,echo=0,link=/dev/ttyZ2M,mode=777",
"master": "pty,raw,echo=0,link=/share/zigbee2mqtt/ttyZ2M,mode=777",
"slave": "tcp-listen:8485,keepalive,nodelay,reuseaddr,keepidle=1,keepintvl=1,keepcnt=5",
"options": "-d -d",
"log": false
Expand Down

2 comments on commit 6597d72

@HarrisonPace
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciotlosm In reference to this commit's change from /dev/ttyZ2M to /share/zigbee2mqtt to fix #24 . Given the /share/zigbee2mqtt/ directory is used for data, logging and configuration. It might make sense to expose the serial device from /tmp/ttyZ2M instead? The user shouldn't have access to a tty device from their configuration folder. It also is temporary in the sense its recreated every time the container is loaded.

@ciotlosm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciotlosm In reference to this commit's change from /dev/ttyZ2M to /share/zigbee2mqtt to fix #24 . Given the /share/zigbee2mqtt/ directory is used for data, logging and configuration. It might make sense to expose the serial device from /tmp/ttyZ2M instead? The user shouldn't have access to a tty device from their configuration folder. It also is temporary in the sense its recreated every time the container is loaded.

Thanks for the tip, i've released 1.71.1-4 with /tmp path instead.

Please sign in to comment.