Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow applying aspects only to handlers with Request input (#3141) #3150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

987Nabil
Copy link
Contributor

@987Nabil 987Nabil commented Sep 18, 2024

The actual bug was, that the handler aspect could be applied to a handler that has a input different then request. There was a construct that should have prevented it, but it did not work.

To make it easier to add aspects to a single route, I added @@ methods to Route too. And a test that shows, that it works with path parameters

fixes #3141
/claim #3141

@987Nabil
Copy link
Contributor Author

987Nabil commented Sep 18, 2024

@jdegoes This is not binary compatible. In fact it would make code not compile that compiled before. But that code would be impossible to run anyway.

I tried to make it possible to apply context aspects to arbitrary handlers, but from what I see, that is not possible.
If you have an idea how it could work let me know. But I fear this breaking change is our best option 😞

The only other good way I see is to deprecate the method and find a new operator.

@Petter-K
Copy link
Contributor

Petter-K commented Oct 3, 2024

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassCassException when using HandlerAspect and Path parameters.
2 participants