Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rewrite the EOCD/EOCD64 detection to fix extreme performance regression #247

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

fix: rewrite the EOCD/EOCD64 detection to fix extreme performance regression #247

wants to merge 21 commits into from
+817 −526

Commits on Oct 20, 2024

  1. fix: resolve clippy warning in nightly

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    605f243 View commit details
    Browse the repository at this point in the history

  2. wip: major rework of cde location

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    1c00e11 View commit details
    Browse the repository at this point in the history

  3. wip: rework CDE lookup

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    157da75 View commit details
    Browse the repository at this point in the history

  4. refactor: magic finder, eocd lookup retry

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    a982a59 View commit details
    Browse the repository at this point in the history

  5. wip: handle empty zips

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    15bd50a View commit details
    Browse the repository at this point in the history

  6. fix: satisfy tests, add documentation

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    91be415 View commit details
    Browse the repository at this point in the history

  7. chore: remove unused dependencies

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    10ca275 View commit details
    Browse the repository at this point in the history

  8. feat: support both zip32 and zip64 comments

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    9b5a987 View commit details
    Browse the repository at this point in the history

  9. feat: add zip64 comment functions to ZipWriter

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    eed5788 View commit details
    Browse the repository at this point in the history

  10. fix: first pass on maintainer comments

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    5050e1f View commit details
    Browse the repository at this point in the history

  11. fix: continue searching for EOCD when the central directory is invalid

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    63b959b View commit details
    Browse the repository at this point in the history

  12. chore: satisfy clippy lints

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    4e6700a View commit details
    Browse the repository at this point in the history

  13. chore: satisfy style_and_docs

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    0f7b326 View commit details
    Browse the repository at this point in the history

  14. feat: support both directions in MagicFinder, correctly find first CDFH

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    37a431b View commit details
    Browse the repository at this point in the history

  15. fix: more checks to EOCD parsing, move comment size error from parse … 

    …to write
    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    eb0a2b8 View commit details
    Browse the repository at this point in the history

  16. fix: use saturating add when checking eocd64 record_size upper bound

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    bc27ed0 View commit details
    Browse the repository at this point in the history

  17. fix: correctly handle mid window offsets in forward mode

    @RisaI
    RisaI committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    1435707 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. fix: compare maximum possible comment length against file size, not s… 

    …earch region end
    @RisaI
    RisaI committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3c04567 View commit details
    Browse the repository at this point in the history

  2. feat: handle zip64 detection as a hint

    @RisaI
    RisaI committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8d542b6 View commit details
    Browse the repository at this point in the history

  3. fix: detect oversized central directories when locating EOCD64

    @RisaI
    RisaI committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    300810f View commit details
    Browse the repository at this point in the history

  4. fix: oopsie

    @RisaI
    RisaI committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    24ad65f View commit details
    Browse the repository at this point in the history