-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/jwt-auth #9
base: feat/chainlink-function
Are you sure you want to change the base?
Conversation
packages/contracts/src/JwtAuth.sol
Outdated
function authJwt(JwtProof memory proof) public onlyOwner { | ||
|
||
// require( | ||
// accountSalt == proof.accountSalt, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyas-londhe
For jwt-tx-builder, I want to make sure that this process is not necessary because I do not think that the specification to create a JwtAuth contract for each different accountSalt. If you want to create a JwtAuth for each domainName or azp, please let me know
why is this being merged into chainlink-fn? those should be two seperate PRs up to main -- we want to merge this ASAP but chainlink functions is fine if it takes a few more days |
This PR is forked from the chainlink function branch to make changes As for Chainlink Functions, it will take a little more time. |
Description
This is the draft PR, it doesn't include any test cases for JwtAuth. We'll discuss the specs in this PR and I'll brush up on implementation and testing.
Type of Change
Please delete options that are not relevant.
Checklist: