Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/jwt-auth #9

Draft
wants to merge 14 commits into
base: feat/chainlink-function
Choose a base branch
from
Draft

Feat/jwt-auth #9

wants to merge 14 commits into from

Conversation

wshino
Copy link
Contributor

@wshino wshino commented Dec 10, 2024

Description

This is the draft PR, it doesn't include any test cases for JwtAuth. We'll discuss the specs in this PR and I'll brush up on implementation and testing.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

function authJwt(JwtProof memory proof) public onlyOwner {

// require(
// accountSalt == proof.accountSalt,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyas-londhe
For jwt-tx-builder, I want to make sure that this process is not necessary because I do not think that the specification to create a JwtAuth contract for each different accountSalt. If you want to create a JwtAuth for each domainName or azp, please let me know

@Divide-By-0
Copy link
Member

Divide-By-0 commented Dec 11, 2024

why is this being merged into chainlink-fn? those should be two seperate PRs up to main -- we want to merge this ASAP but chainlink functions is fine if it takes a few more days

@wshino wshino changed the base branch from feat/chainlink-function to main December 11, 2024 07:59
@wshino wshino changed the base branch from main to feat/chainlink-function December 11, 2024 07:59
@wshino
Copy link
Contributor Author

wshino commented Dec 11, 2024

@Divide-By-0

why is this being merged into chainlink-fn? those should be two seperate PRs up to main -- we want to merge this ASAP but chainlink functions is fine if it takes a few more days

This PR is forked from the chainlink function branch to make changes
If we want to merge to the main branch immediately, I'll create another PR from the main branch. What do you think about this proposal? The deploy script and integration test are the remaining work.

As for Chainlink Functions, it will take a little more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants