refactor codebase for new euclid workflow usage with tests #54
Conversation
There was a problem hiding this comment.
Hey Toyosi,
Gonna preface I dont know bajor that well so this might not be my best PR review. Knowing that the goal of this PR is to get zoobot training/predictions job to work for more than 1 project (i.e. 2 projects), I think we can do more abstraction if needed later once we know more use cases.
I had a couple questions that either you, @lcjohnso or Mike might be able to answer.
| @@ -38,6 +39,15 @@ | |||
| parser.add_argument('--debug', dest='debug', default=False, action='store_true') | |||
| args = parser.parse_args() | |||
|
|
|||
| schema_dict = { | |||
| 'cosmic_dawn': cosmic_dawn_ortho_schema, | |||
| 'euclid': { | |||
There was a problem hiding this comment.
Just wondering.
is there a reason we can't use zoobot.shared.schemas' euclid_schemas? https://github.com/mwalmsley/zoobot/blob/main/zoobot/shared/schemas.py#L304
There was a problem hiding this comment.
do we have a schema for decals as well?
There was a problem hiding this comment.
We agreed to have hard-coded for test now as we aren't on the latest zoobot version - We plan to upgrade but this just for test purposes. This would be removed immediately after
There was a problem hiding this comment.
Can you add an issue so we don't forget to do this?
There was a problem hiding this comment.
Yes, added that here: #55
Codebase changes for new euclid workflow