Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump azure/login from 1 to 2 #5949

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Bumps azure/login from 1 to 2.

Release notes

Sourced from azure/login's releases.

Azure Login Action v2

What's Changed

New Contributors

Full Changelog: Azure/login@v1.6.1...v2

Azure Login Action v1.6.1

  • Fix #403: Do not break the workflow if az is not installed in pre and post steps

Azure Login Action v1.6.0

  • Added pre: and post: action for cleaning up (#384)

Azure Login Action v1.5.1

  • Fixed #371: Allow optional subscriptionId in creds (#373)
  • Cleaned accounts before login (#376, #377)
  • Updated actions-secret-parser from 1.0.2 to 1.0.4 (#378)

Azure Login Action v1.5.0

  • Updated the versions of dependencies.
  • Supported passwords to start with hyphen(-).
  • Enabled OIDC for sovereign clouds.
  • Supported Managed Identity Login.

[BUG FIX] Version pattern regex update

No release notes provided.

Handling id-token error and Node version upgradation

In this release, a separate error will be thrown if id-token permissions are not set in the workflow for OIDC login. Also upgraded the Node version to 16.

Handling warnings and added OIDC promotional note.

Error handling and minor doc changes.

Added az installation requirement in the error response

No release notes provided.

Added federated token details in logs

Displaying OIDC token details - subject claim and issuer in the logs.

Added audience parameter and CLI,PS logs

An explicit input parameter called audience is added to allow the option provided in the azure portal. Also CLI and powershell errors are being surfaced inside the action.

Added OIDC support

Login Action now supports two different ways of authentication with Azure. One using the Azure Service Principal with secrets. We now added the new OpenID Connect (OIDC) method of authentication using Azure Service Principal with a Federated Identity Credential.

Adding Azure PowerShell login changes

With the Azure login Action, you can automate your workflow to do an Azure login using Azure service principal and run Az CLI and Azure PowerShell scripts.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [azure/login](https://github.com/azure/login) from 1 to 2.
- [Release notes](https://github.com/azure/login/releases)
- [Commits](Azure/login@v1...v2)

---
updated-dependencies:
- dependency-name: azure/login
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Mar 4, 2024
@coveralls
Copy link

coveralls commented Mar 4, 2024

Coverage Status

coverage: 80.711% (-0.003%) from 80.714%
when pulling 037d299 on dependabot/github_actions/azure/login-2
into b889392 on master.

@goplayoutside3
Copy link
Contributor

@zwolf any reason not to bump azure/login? This branch looks fine locally and all Actions are passing.

@zwolf
Copy link
Member

zwolf commented Mar 12, 2024

There's no action in this repo that will test if this (specifically, the interaction between github actions & azure) will work. I expect it will, but the major release is only a week old. I can run tests on the ci-cd repo to ensure this version will work with the same syntax in the shared workflows and I'll be checking those manually (dependabot doesn't run them for permissions reasons). FEM is special and doesn't use the shared ones though, so best practice would probably be to hold off until I've got the updated the version in the shared workflow confirmed working.

if you're feeling like yoloing it though it's easy to roll back and will stop those node version warnings.

@zwolf
Copy link
Member

zwolf commented Mar 12, 2024

Updated the shared ones here and they look find, go for it!

zooniverse/ci-cd#68

@github-actions github-actions bot added the approved This PR is approved for merging label Mar 13, 2024
@goplayoutside3 goplayoutside3 enabled auto-merge (squash) March 13, 2024 13:10
@goplayoutside3 goplayoutside3 merged commit 74af0f2 into master Mar 13, 2024
7 checks passed
@goplayoutside3 goplayoutside3 deleted the dependabot/github_actions/azure/login-2 branch March 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants