Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app-project): data-fetching for assigned workflow level #6219

Merged
merged 8 commits into from
Nov 13, 2024
Merged

fix(app-project): data-fetching for assigned workflow level #6219

merged 8 commits into from
Nov 13, 2024

Commits on Nov 13, 2024

  1. fix(app-project): data-fetching for assigned workflow level 

    Fix missing dependency errors in the `useAssignedLevel` hook by using `useSWR` to fetch and cache the assigned workflow level. SWR also adds revalidation for cases where I might classify in the same tab over several days or weeks.

Also fixes the workflow assignment tests in `ClassifyPageContainer` so that they test against the correct levels.
    @eatyourgreens @goplayoutside3
    eatyourgreens authored and goplayoutside3 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fe76786 View commit details
    Browse the repository at this point in the history

  2. Check workflows from page props for faster performance

    @eatyourgreens @goplayoutside3
    eatyourgreens authored and goplayoutside3 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5063e15 View commit details
    Browse the repository at this point in the history

  3. The default assigned workflow level can be higher than 1

    @eatyourgreens @goplayoutside3
    eatyourgreens authored and goplayoutside3 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ec16796 View commit details
    Browse the repository at this point in the history

  4. remove unused imports

    @eatyourgreens @goplayoutside3
    eatyourgreens authored and goplayoutside3 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    27644f4 View commit details
    Browse the repository at this point in the history

  5. avoid returning NaN for the workflow level

    @eatyourgreens @goplayoutside3
    eatyourgreens authored and goplayoutside3 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b8557ea View commit details
    Browse the repository at this point in the history

  6. don't refetch unless assignedWorkflowID changes

    @eatyourgreens @goplayoutside3
    eatyourgreens authored and goplayoutside3 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    75cbd42 View commit details
    Browse the repository at this point in the history

  7. switch to useSWRImmutable

    @eatyourgreens @goplayoutside3
    eatyourgreens authored and goplayoutside3 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f22b905 View commit details
    Browse the repository at this point in the history

  8. useSWR instead of useSWRImmutable

    @goplayoutside3
    goplayoutside3 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b3f6693 View commit details
    Browse the repository at this point in the history