Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ERAS for all user stats in YourStats component #6401

Closed
wants to merge 6 commits into from

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Oct 23, 2024

Package

app-project
lib-classifier

Linked Issue and/or Talk Post

Closes: #6400
Closes: #5964
Closes: #5134

Describe your changes

  • Remove activity_count everywhere in FEM so user stats are no longer using /project_preferences for calculating classification count.
  • Untangle the spaghetti code of UPP > YourStats MST files.
  • Add a disposer function with autorun to Store.js so that UserPersonalization refreshes every time the project id changes. This ensures the YourStats component displays correct stats data if you keep the same tab open and switch between FEM projects.

How to Review

  • View any project's classify page and YourStats total classification count should match the total classification count displayed on your stats and homepage.
  • When you make a classification, the YourStats component should increment as expected.
  • See more comments below about removing legacy code.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out

Bug Fix

  • The PR creator has listed user actions to use when testing if bug is fixed
  • The bug is fixed
  • Unit tests are added or updated

Refactoring

  • The PR creator has described the reason for refactoring
  • The refactored component(s) continue to work as expected

@coveralls
Copy link

coveralls commented Oct 28, 2024

Coverage Status

coverage: 77.786% (+0.02%) from 77.764%
when pulling ffde57d on UPP-clean-up
into f58b7ba on master.

@goplayoutside3
Copy link
Contributor Author

Superseded by #6472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants