-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR 61: Displaying Stats in UTC Date Ranges #6442
Conversation
@seanmiller26 we already chatted on Slack about the x-axis label. Here are the screenshots again for reference. Here's a screenshot of the FAQ question + answer. The text is easily revised before or after this PR is merged if needed. |
@mcbouslog I'm requesting your code review because your familiarity with the BarChart. @kieftrav and @shaunanoordin I've tagged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADR breaks down the topic well, I really appreciate/like the examples.
FAQ item is helpful reference 👍 .
BarChart content looks good across screens/theme.
Noting default end date (i.e. here in UserStats or GroupStats) will be UTC date, consistent with this ADR.
Co-authored-by: Mark Bouslog <[email protected]>
Co-authored-by: Mark Bouslog <[email protected]>
Package
lib-user
lib-content
Linked Issue and/or Talk Post
Toward: #6400
Describe your changes
How to Review
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expected