Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert type comments to Python ≥ 3.6 variable annotations #794

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

andersk
Copy link
Member

@andersk andersk commented Oct 18, 2023

No description provided.

@neiljp
Copy link
Contributor

neiljp commented Oct 18, 2023

This is via pyupgrade? It'd be great to see this change 👍

Reading some of this, it reminds me it'd be great to have a typeddict for more of the interface. As a first step that'd be easiest with something like PrivateComposition/StreamComposition (as currently in zulip-terminal), extending potentially into Message - which is so much more complex.

@andersk andersk merged commit a9607df into zulip:main Oct 25, 2023
13 checks passed
@andersk andersk deleted the com2ann branch October 25, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants