Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-reload behavior when connected to an invalid organization is buggy #877

Open
timabbott opened this issue Mar 1, 2020 · 11 comments · May be fixed by #1394
Open

Auto-reload behavior when connected to an invalid organization is buggy #877

timabbott opened this issue Mar 1, 2020 · 11 comments · May be fixed by #1394
Assignees
@Vansh5632
Labels
help wanted in progress Type: Bug

Comments

@timabbott
Copy link
Member

timabbott commented Mar 1, 2020 •
edited
Loading

You can easily reproduce this as follows:

  • Connect to an unavailable organization (e.g. localhost:10000, or localhost:9991 with no development server running).
  • Try to go to the settings UI
  • After a few seconds, you'll be navigated back to the unavailable organization's page, as part of the app's auto-reconnect retry behavior.

What we should fix:

  • The auto-retry behavior shouldn't move the focus to the tab at all; it should just reload in the background. I don't see any situation where we'd want that navigation/focus change to happen; it's probably just code in a common code path with adding a new organization that's in the wrong place (or something).
  • We probably aren't doing a reasonable exponential backoff for these retries. See https://chat.zulip.org/#narrow/stream/92-learning/topic/exponential.20backoff.20--.20with.20jitter/near/818761 for discussion on how this sort of backoff should be done.
@manavmehta
Copy link
Collaborator

If the organisation doesn't exist then it shouldn't get added in the first place.
I am not sure how anyone would be able to add an unavailable organisation.
@timabbott

@adityamudgil2505
Copy link
Collaborator

When I connect to localhost:10000 it instantly gives me an error.
Screenshot 2020-03-04 at 1 56 44 PM
@timabbott Can you elaborate on what we are trying to solve?

@Somtozech
Copy link

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @Somtozech! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@Somtozech
Copy link

@zulipbot claim

@zulipbot
Copy link
Member

Hello @Somtozech, it looks like we've already sent you a collaboration invite at https://github.com/zulip/zulip-desktop/invitations, but you haven't accepted it yet!

Please accept the invite and try to claim this issue again afterwards. We look forward to your contributions!

@Somtozech
Copy link

@timabbott am trying to claim the issue. When I try to accept the invitation I get the error Sorry, we couldn't find that repository invitation. It is possible that the invitation was revoked or that you are not logged into the invited account. A screenshot is attached
invite issues

@PawBud
Copy link
Collaborator

PawBud commented Aug 12, 2020

2020-08-12-18-35-00
I would love to work on this bug, but I am not really able to reproduce it. Am I doing something wrong?

Version: v5.4.1-beta, (this is NOT the development version).
OS:- Ubuntu 20.04 LTS (Focal Fossa)

@timabbott
Copy link
Member Author

That reproduction attempt doesn't look right -- you need to connect to multiple organizations successfully (say chat.zulip.org and your development server), and then shut down your development server and try starting the app.

@Vansh5632
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @Vansh5632! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@Vansh5632 Vansh5632 linked a pull request Nov 18, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vansh5632 Vansh5632

Labels
help wanted in progress Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue 887: fixed auto reloading and enable background reloading Vansh5632/zulip-desktop
7 participants
@timabbott @zulipbot @adityamudgil2505 @manavmehta @Somtozech @PawBud @Vansh5632