Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 887: fixed auto reloading and enable background reloading #1394

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vansh5632
Copy link
Collaborator

@Vansh5632 Vansh5632 commented Nov 18, 2024

What's this PR do?
Fixes #877
Introduces a ReconnectUtil class to manage internet connection interruptions in WebView, with a Fibonacci backoff strategy for reconnection attempts and graceful error handling.

Any background context you want to provide?
The utility provides a robust mechanism for handling temporary network disconnections, with:

  • Fibonacci backoff to prevent overwhelming network resources
  • Background webview reloading
  • Detailed logging
  • User-friendly offline error messaging

You have tested this PR on:

  • Windows
  • Linux/Ubuntu
  • macOS

@timabbott
Copy link
Member

Please self-review and clean up your PR; .vagrant should not be present :).

@zulipbot zulipbot added size: M and removed size: L labels Nov 20, 2024
@zulipbot
Copy link
Member

Hello @Vansh5632, it seems like you have referenced #877 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #877..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

@whilstsomebody
Copy link

Hi @Vansh5632 , please read the contribution guide before moving ahead. Before any further review, you have to correct your PR:

  • Clean the commit history.
  • Provide some screenshots of you changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-reload behavior when connected to an invalid organization is buggy
4 participants