Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf_desktop migration guide cs3 - ncs2.7 #1

Closed

Conversation

zycz
Copy link
Owner

@zycz zycz commented Jun 18, 2024

nrf_desktop migration guide cs3 - ncs2.7

@zycz zycz force-pushed the Add_nrf_desktop_migration_guide branch 3 times, most recently from 65a2d87 to 3e88e12 Compare June 19, 2024 13:07
@zycz zycz changed the title wip nrf_desktop migration guide cs3 - ncs2.7 Jun 19, 2024
Copy link

@mkapala-nordic mkapala-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider placing related notes next to each other as it seems that radio core related ones are scattered on the begining, middle and the end of the migration guide

@@ -74,6 +74,40 @@ General

The previously used SOC1-based board files have been removed.

NRF Desktop

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nRF Desktop?

NRF Desktop
-----------

The following changes have to be made for nrf_desktop application to work in the same way as in the release v2.4.99-cs3 .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following changes have to be made for nrf_desktop application to work in the same way as in the release v2.4.99-cs3 .
The following changes have to be made for :ref:`nrf_desktop` application to work in the same way as in the release v2.4.99-cs3 .


The following changes have to be made for nrf_desktop application to work in the same way as in the release v2.4.99-cs3 .

* Because of hardware model v2 the building command for application has changed and it is now:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like that to show that only the <board> part has changed?

Due to the migration to the new hardware model, commonly referred as "hardware model v2", the board target of the nRF54H20 DK has changed to the ``nrf54h20dk/nrf54h20/cpuapp``.


west build -b nrf54h20dk/nrf54h20/cpuapp

* For radio core image hci_rpmsg was removed and replaced with ipc_radio.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* For radio core image hci_rpmsg was removed and replaced with ipc_radio.
* Radio core now uses the :ref:`ipc_radio` application from ``sdk-nrf`` instead of the Bluetooth HCI IPC sample from ``sdk-zephyr``.

west build -b nrf54h20dk/nrf54h20/cpuapp

* For radio core image hci_rpmsg was removed and replaced with ipc_radio.
* Sample uses default memory map.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Sample uses default memory map.
* Application uses the default memory map.

Comment on lines 93 to 108
* Moved to using USB-next new stack for USB support.
New kconfig option :kconfig:option:`CONFIG_DESKTOP_USB_STACK_NEXT` has been added to enable it.
See commits how to integrate it to nrf_desktop application:

* https://github.com/nrfconnect/sdk-nrf/commit/3c1a3ec4b7e9df3aa70333c761655ea7bb38bc8e
* https://github.com/nrfconnect/sdk-nrf/commit/290d421ee505e6f57decd48a5aea78f238060865
* https://github.com/nrfconnect/sdk-nrf/commit/c57fc2d78f87345929d6395bfcf40f83ff9b33b5
* https://github.com/nrfconnect/sdk-nrf/commit/16492f54dbe6d89f37fcd499bf34346118edb327
Copy link

@mkapala-nordic mkapala-nordic Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need those commit list here?
It is not "how to integrate it" but "how it has been integrated".
Won't the information that the USB High-Speed is only available on the USB next stack thus needed for nRF54H be enough?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for rest should we place commits here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for others input then.
If commits won't be necessary then consider replacing it with something like:

* The USB High-Speed is supported only in the USB next stack.
  New USB next stack has been integrated into the nRF Desktop application and can be enabled using the :kconfig:option:`CONFIG_DESKTOP_USB_STACK_NEXT` Kconfig option.
  It is now enabled by default in the nRF54H20 DK configurations.

* https://github.com/nrfconnect/sdk-nrf/commit/c57fc2d78f87345929d6395bfcf40f83ff9b33b5
* https://github.com/nrfconnect/sdk-nrf/commit/16492f54dbe6d89f37fcd499bf34346118edb327

* Radio core configuration files have been moved from :file:`configuration/nrf54h20dk_nrf54h20_cpuapp/child_image/hci_rpmsg` to :file:`configuration/nrf54h20dk_nrf54h20_cpurad` directory.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it related to sysbuild? Also we migrated to the ipc_radio, and this sentence for me suggests that we have hci_rpmsg configs still in the app.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will place it near information that we remove hci_rpmsg. Yes it is sysbuild info but still I think it is worth placing it here to show how it impacts this application

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe:

* Due to the migration to sysbuild, radio core image configuration files have been moved from the :file:`configuration/nrf54h20dk_nrf54h20_cpuapp/child_image` to :file:`configuration/nrf54h20dk_nrf54h20_cpurad/images` directory.

Comment on lines 103 to 111
* Align FLASH writes in dfu application module to FLASH write block of non-volatile memory.
See commit: https://github.com/nrfconnect/sdk-nrf/commit/becbed095fa9f732d2e3a4b21a65fd8f36694601
Copy link

@mkapala-nordic mkapala-nordic Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need commit here?
It is just an improvement of nRF Desktop in my opinion, is it worth to mention it here?

Suggested change
* Align FLASH writes in dfu application module to FLASH write block of non-volatile memory.
See commit: https://github.com/nrfconnect/sdk-nrf/commit/becbed095fa9f732d2e3a4b21a65fd8f36694601
* Align FLASH writes in the :ref:`nrf_desktop_dfu` to FLASH write block size of the non-volatile memory.
See commit: https://github.com/nrfconnect/sdk-nrf/commit/becbed095fa9f732d2e3a4b21a65fd8f36694601

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above regarding keeping commits

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Commits -> ok, let's wait for others input.
  2. Note itself -> Do we even need that note ("It is just an improvement of nRF Desktop IMO")

Comment on lines 105 to 106
* Due to transition to sysbuild build system options regarding usage of radio core have been moved from prj.conf to sysbuild.conf.
NRF Desktop nRF54H20 significant options which are set in sysbuild.conf:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Due to transition to sysbuild build system options regarding usage of radio core have been moved from prj.conf to sysbuild.conf.
NRF Desktop nRF54H20 significant options which are set in sysbuild.conf:
* Due to transition to sysbuild, configuration of radio core image has been moved from the main application configuration to the sysbuild configuration.
See the following sysbuild Kconfig options related to the radio core image configuration:


* For radio core image hci_rpmsg was removed and replaced with ipc_radio.
* Sample uses default memory map.
* Module :file:`dfu_mcumgr_suit.c` had been merged to :file:`dfu_mcumgr.c`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Module :file:`dfu_mcumgr_suit.c` had been merged to :file:`dfu_mcumgr.c`.
* Module :file:`dfu_mcumgr_suit.c` has been merged with :file:`dfu_mcumgr.c`.

@zycz zycz force-pushed the Add_nrf_desktop_migration_guide branch from 3e88e12 to f82d50f Compare June 19, 2024 14:26
@zycz zycz requested a review from mkapala-nordic June 19, 2024 14:27

* Align FLASH writes in the :ref:`nrf_desktop_dfu` to FLASH write block size of the non-volatile memory.
See commit: https://github.com/nrfconnect/sdk-nrf/commit/becbed095fa9f732d2e3a4b21a65fd8f36694601
* Due to transition to sysbuild, configuration of radio core image has been moved from the main application configuration to the sysbuild configuration.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move it before * Application uses the default memory map. to group radio core related stuff

@zycz zycz force-pushed the Add_nrf_desktop_migration_guide branch from f82d50f to 52da3d4 Compare June 20, 2024 07:23
@zycz zycz requested a review from mkapala-nordic June 20, 2024 07:23

west build -b nrf54h20dk/nrf54h20/cpuapp

* Radio core now uses the :ref:`ipc_radio` application from ``sdk-nrf`` instead of the Bluetooth HCI IPC sample from ``sdk-zephyr``.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at configurations it used to use HCI RPMsg, right?

west build -b nrf54h20dk/nrf54h20/cpuapp

* Radio core now uses the :ref:`ipc_radio` application from ``sdk-nrf`` instead of the Bluetooth HCI IPC sample from ``sdk-zephyr``.
* Radio core configuration files have been moved from :file:`configuration/nrf54h20dk_nrf54h20_cpuapp/child_image/hci_rpmsg` to :file:`configuration/nrf54h20dk_nrf54h20_cpurad` directory.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Radio core image configuration files ..... to :file:`configuration/nrf54h20dk_nrf54h20_cpurad/images/ipc_radio` 

Now DFU over SMP is enabled by default in the ``debug`` and ``release`` configurations.
* Moved to using USB-next new stack for USB support.
New kconfig option :kconfig:option:`CONFIG_DESKTOP_USB_STACK_NEXT` has been added to enable it.
See commits "how it has been integrated to nrf_desktop application:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could link to USB state module documentation here instead of adding links to commits?


* Radio core now uses the :ref:`ipc_radio` application from ``sdk-nrf`` instead of the Bluetooth HCI IPC sample from ``sdk-zephyr``.
* Radio core configuration files have been moved from :file:`configuration/nrf54h20dk_nrf54h20_cpuapp/child_image/hci_rpmsg` to :file:`configuration/nrf54h20dk_nrf54h20_cpurad` directory.
* Due to transition to sysbuild, configuration of radio core image has been moved from the main application configuration to the sysbuild configuration.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuration enabling radio core image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main application image configuration


* ``SB_CONFIG_NRF_DEFAULT_IPC_RADIO``
* ``SB_CONFIG_NETCORE_IPC_RADIO_BT_HCI_IPC``
* Application uses the default memory map.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider explicitly mentioning that it no longer defines an application-specific memory map.

* ``SB_CONFIG_NETCORE_IPC_RADIO_BT_HCI_IPC``
* Application uses the default memory map.
* Module :file:`dfu_mcumgr_suit.c` has been merged with :file:`dfu_mcumgr.c`.
The ``CONFIG_DESKTOP_DFU_MCUMGR_SUIT_ENABLE`` Kconfig option had been removed and replaced by :kconfig:option:`CONFIG_DESKTOP_DFU_BACKEND_SUIT`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix references to nRF Desktop specific Kconfigs - use the following syntax:

:ref:`CONFIG_DESKTOP_FN_KEYS_SWITCH <config_desktop_app_options>`

* The :file:`prj_suit_smp.conf` configuration for nRF54H20 DK has been removed.
Now DFU over SMP is enabled by default in the ``debug`` and ``release`` configurations.
* Moved to using USB-next new stack for USB support.
New kconfig option :kconfig:option:`CONFIG_DESKTOP_USB_STACK_NEXT` has been added to enable it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also inform that USB HID configuration is different now (it was moved to DTS)

@zycz zycz force-pushed the Add_nrf_desktop_migration_guide branch from 52da3d4 to d96074f Compare June 21, 2024 13:01

* Application uses the default memory map based on Zephyr board files and no longer defines an application-specific memory map.
* Module :file:`dfu_mcumgr_suit.c` has been merged with :file:`dfu_mcumgr.c`.
The ``CONFIG_DESKTOP_DFU_MCUMGR_SUIT_ENABLE`` Kconfig option had been removed and replaced by :ref:`CONFIG_DESKTOP_DFU_BACKEND_SUIT`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nRF Desktop Kconfig option references are still wrong.

The ``CONFIG_DESKTOP_DFU_MCUMGR_SUIT_ENABLE`` Kconfig option had been removed and replaced by :ref:`CONFIG_DESKTOP_DFU_BACKEND_SUIT`.
* The :file:`prj_suit_smp.conf` configuration for nRF54H20 DK has been removed.
Now DFU over SMP is enabled by default in the ``debug`` and ``release`` configurations.
* Moved to using USB-next new stack for USB support.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

USB-next stack

* The :file:`prj_suit_smp.conf` configuration for nRF54H20 DK has been removed.
Now DFU over SMP is enabled by default in the ``debug`` and ``release`` configurations.
* Moved to using USB-next new stack for USB support.
New kconfig option :ref:`CONFIG_DESKTOP_USB_STACK_NEXT` has been added to enable it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to enable it in nRF Desktop application

Now DFU over SMP is enabled by default in the ``debug`` and ``release`` configurations.
* Moved to using USB-next new stack for USB support.
New kconfig option :ref:`CONFIG_DESKTOP_USB_STACK_NEXT` has been added to enable it.
USB HID-class instance is now configured through a separate DTS node compatible with ``zephyr,hid-device``.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An USB HID-class insance ...

* Moved to using USB-next new stack for USB support.
New kconfig option :ref:`CONFIG_DESKTOP_USB_STACK_NEXT` has been added to enable it.
USB HID-class instance is now configured through a separate DTS node compatible with ``zephyr,hid-device``.
See usb_state documentation on how to integrate USB-next stack: :ref:`nrf_desktop_usb_state`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See :ref:nrf_desktop_usb_state documentation for details related to USB-next stack integration

@zycz zycz force-pushed the Add_nrf_desktop_migration_guide branch from d96074f to 8a1755a Compare June 21, 2024 13:42
nRF Desktop
-----------

The following changes have to be made for :ref:`nrf_desktop` application to work in the same way as in the release v2.4.99-cs3.
Copy link

@peknis peknis Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following changes have to be made for :ref:`nrf_desktop` application to work in the same way as in the release v2.4.99-cs3.
You need to make the following changes for the :ref:`nrf_desktop` application to work in the same way as in the release v2.4.99-cs3.


The following changes have to be made for :ref:`nrf_desktop` application to work in the same way as in the release v2.4.99-cs3.

* Due to the migration to the new hardware model, commonly referred as "hardware model v2", the board target of the nRF54H20 DK has changed to the ``nrf54h20dk/nrf54h20/cpuapp``.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Due to the migration to the new hardware model, commonly referred as "hardware model v2", the board target of the nRF54H20 DK has changed to the ``nrf54h20dk/nrf54h20/cpuapp``.
* Due to the migration to the new hardware model, commonly referred as "hardware model v2", the board target of the nRF54H20 DK has changed to ``nrf54h20dk/nrf54h20/cpuapp``.

The following changes have to be made for :ref:`nrf_desktop` application to work in the same way as in the release v2.4.99-cs3.

* Due to the migration to the new hardware model, commonly referred as "hardware model v2", the board target of the nRF54H20 DK has changed to the ``nrf54h20dk/nrf54h20/cpuapp``.
Building command for application has changed and it is now:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Building command for application has changed and it is now:
The build command for the application has changed and it is now:


west build -b nrf54h20dk/nrf54h20/cpuapp

* Radio core now uses the :ref:`ipc_radio` application from ``sdk-nrf`` instead of the Bluetooth HCI RPMsg sample from ``sdk-zephyr``.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, how to link it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ref:zephyr:bluetooth-hci-ipc-sample


* Radio core now uses the :ref:`ipc_radio` application from ``sdk-nrf`` instead of the Bluetooth HCI RPMsg sample from ``sdk-zephyr``.
* Radio core image configuration files have been moved from :file:`configuration/nrf54h20dk_nrf54h20_cpuapp/child_image/hci_rpmsg` to :file:`configuration/nrf54h20dk_nrf54h20_cpurad/images/ipc_radio` directory.
* Due to transition to sysbuild, configuration enabling radio core image has been moved from the main application image configuration to the sysbuild configuration.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Due to transition to sysbuild, configuration enabling radio core image has been moved from the main application image configuration to the sysbuild configuration.
* Due to transition to sysbuild, the configuration enabling the radio core image has been moved from the main application image configuration to the sysbuild configuration.

* Application uses the default memory map based on Zephyr board files and no longer defines an application-specific memory map.
* Module :file:`dfu_mcumgr_suit.c` has been merged with :file:`dfu_mcumgr.c`.
The ``CONFIG_DESKTOP_DFU_MCUMGR_SUIT_ENABLE`` Kconfig option had been removed and replaced by :ref:`CONFIG_DESKTOP_DFU_BACKEND_SUIT <config_desktop_app_options>`.
* The :file:`prj_suit_smp.conf` configuration for nRF54H20 DK has been removed.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The :file:`prj_suit_smp.conf` configuration for nRF54H20 DK has been removed.
* The :file:`prj_suit_smp.conf` configuration for the nRF54H20 DK has been removed.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed sentence as it is to nrf_desktop specific. Disused offline with Francesco

* Module :file:`dfu_mcumgr_suit.c` has been merged with :file:`dfu_mcumgr.c`.
The ``CONFIG_DESKTOP_DFU_MCUMGR_SUIT_ENABLE`` Kconfig option had been removed and replaced by :ref:`CONFIG_DESKTOP_DFU_BACKEND_SUIT <config_desktop_app_options>`.
* The :file:`prj_suit_smp.conf` configuration for nRF54H20 DK has been removed.
Now DFU over SMP is enabled by default in the ``debug`` and ``release`` configurations.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now DFU over SMP is enabled by default in the ``debug`` and ``release`` configurations.
DFU over SMP is now enabled by default in the ``debug`` and ``release`` configurations.

Copy link
Owner Author

@zycz zycz Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed sentence as it is to nrf_desktop specific. Disused offline with Francesco

* The :file:`prj_suit_smp.conf` configuration for nRF54H20 DK has been removed.
Now DFU over SMP is enabled by default in the ``debug`` and ``release`` configurations.
* Moved to using USB-next stack for USB support.
New kconfig option :ref:`CONFIG_DESKTOP_USB_STACK_NEXT <config_desktop_app_options>` has been added to enable it in nRF Desktop application.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
New kconfig option :ref:`CONFIG_DESKTOP_USB_STACK_NEXT <config_desktop_app_options>` has been added to enable it in nRF Desktop application.
A new kconfig option :ref:`CONFIG_DESKTOP_USB_STACK_NEXT <config_desktop_app_options>` has been added to enable it in nRF Desktop application.

New kconfig option :ref:`CONFIG_DESKTOP_USB_STACK_NEXT <config_desktop_app_options>` has been added to enable it in nRF Desktop application.
An USB HID-class instance is now configured through a separate DTS node compatible with ``zephyr,hid-device``.
See :ref:`nrf_desktop_usb_state` documentation for details related to USB-next stack integration.
* Align FLASH writes in the :ref:`nrf_desktop_dfu` to FLASH write block size of the non-volatile memory.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Align FLASH writes in the :ref:`nrf_desktop_dfu` to FLASH write block size of the non-volatile memory.
* Align flash writes in the :ref:`nrf_desktop_dfu` to the flash write block size of the non-volatile memory.

An USB HID-class instance is now configured through a separate DTS node compatible with ``zephyr,hid-device``.
See :ref:`nrf_desktop_usb_state` documentation for details related to USB-next stack integration.
* Align FLASH writes in the :ref:`nrf_desktop_dfu` to FLASH write block size of the non-volatile memory.
It's needed as :ref:`CONFIG_SOC_FLASH_NRF_MRAM_ONE_BYTE_WRITE_ACCESS <config_desktop_app_options>` is no longer available.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It's needed as :ref:`CONFIG_SOC_FLASH_NRF_MRAM_ONE_BYTE_WRITE_ACCESS <config_desktop_app_options>` is no longer available.
This is needed because the :ref:`CONFIG_SOC_FLASH_NRF_MRAM_ONE_BYTE_WRITE_ACCESS <config_desktop_app_options>` Kconfig option is no longer available.

@zycz zycz force-pushed the Add_nrf_desktop_migration_guide branch from 8a1755a to 9d3f735 Compare June 24, 2024 13:22
@zycz zycz requested a review from peknis June 24, 2024 13:22
Comment on lines +85 to +87
.. code-block:: console

west build -b nrf54h20dk/nrf54h20/cpuapp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. code-block:: console
west build -b nrf54h20dk/nrf54h20/cpuapp
.. code-block:: console
west build -b nrf54h20dk/nrf54h20/cpuapp

west build -b nrf54h20dk/nrf54h20/cpuapp

* The :ref:`ipc_radio` image serves purpose as universal network core image for hci_ipc rpc_host and IEEE 802.15.4 remote image.
Due to that radio core now uses the :ref:`ipc_radio` application from ``sdk-nrf`` instead of the :ref:`zephyr:bluetooth-hci-ipc-sample` sample from ``sdk-zephyr``.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Due to that radio core now uses the :ref:`ipc_radio` application from ``sdk-nrf`` instead of the :ref:`zephyr:bluetooth-hci-ipc-sample` sample from ``sdk-zephyr``.
Due to this, the radio core now uses the :ref:`ipc_radio` application from ``sdk-nrf`` instead of the :ref:`zephyr:bluetooth-hci-ipc-sample` sample from ``sdk-zephyr``.

The ``CONFIG_DESKTOP_DFU_MCUMGR_SUIT_ENABLE`` Kconfig option had been removed and replaced by :ref:`CONFIG_DESKTOP_DFU_BACKEND_SUIT <config_desktop_app_options>`.
The :file:`dfu_mcumgr_suit.c` is no longer needed as in |NCS| v2.7 the dfu_mcumgr module can be properly adapted to support the SUIT DFU.
* The USB High-Speed is supported only in the USB next stack.
New USB next stack has been integrated into the nRF Desktop application and can be enabled using the :kconfig:option:`CONFIG_DESKTOP_USB_STACK_NEXT` Kconfig option.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
New USB next stack has been integrated into the nRF Desktop application and can be enabled using the :kconfig:option:`CONFIG_DESKTOP_USB_STACK_NEXT` Kconfig option.
New USB next stack has been integrated into the nRF Desktop application and you can enable it using the :kconfig:option:`CONFIG_DESKTOP_USB_STACK_NEXT` Kconfig option.


* The :file:`dfu_mcumgr_suit.c` module has been merged with :file:`dfu_mcumgr.c`.
The ``CONFIG_DESKTOP_DFU_MCUMGR_SUIT_ENABLE`` Kconfig option had been removed and replaced by :ref:`CONFIG_DESKTOP_DFU_BACKEND_SUIT <config_desktop_app_options>`.
The :file:`dfu_mcumgr_suit.c` is no longer needed as in |NCS| v2.7 the dfu_mcumgr module can be properly adapted to support the SUIT DFU.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The :file:`dfu_mcumgr_suit.c` is no longer needed as in |NCS| v2.7 the dfu_mcumgr module can be properly adapted to support the SUIT DFU.
The :file:`dfu_mcumgr_suit.c` file is no longer needed as in the |NCS| v2.7.0 the :ref: `nrf_desktop_dfu_mcumgr` module can be properly adapted to support the SUIT DFU.

* The USB High-Speed is supported only in the USB next stack.
New USB next stack has been integrated into the nRF Desktop application and can be enabled using the :kconfig:option:`CONFIG_DESKTOP_USB_STACK_NEXT` Kconfig option.
It is now enabled by default in the nRF54H20 DK configurations.
An USB HID-class instance is now configured through a separate DTS node compatible with ``zephyr,hid-device``.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An USB HID-class instance is now configured through a separate DTS node compatible with ``zephyr,hid-device``.
A USB HID-class instance is now configured through a separate DTS node compatible with ``zephyr,hid-device``.

An USB HID-class instance is now configured through a separate DTS node compatible with ``zephyr,hid-device``.
See :ref:`nrf_desktop_usb_state` documentation for details related to USB-next stack integration.
* Align flash writes in the :ref:`nrf_desktop_dfu` to the flash write block size of the non-volatile memory.
This is needed because the :ref:`CONFIG_SOC_FLASH_NRF_MRAM_ONE_BYTE_WRITE_ACCESS <config_desktop_app_options>` Kconfig option is no longer available and MRAMC requiers writes of the size of the whole MRAM word to the MRAM.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is needed because the :ref:`CONFIG_SOC_FLASH_NRF_MRAM_ONE_BYTE_WRITE_ACCESS <config_desktop_app_options>` Kconfig option is no longer available and MRAMC requiers writes of the size of the whole MRAM word to the MRAM.
This is needed because the :ref:`CONFIG_SOC_FLASH_NRF_MRAM_ONE_BYTE_WRITE_ACCESS <config_desktop_app_options>` Kconfig option is no longer available and MRAMC requires writes to the MRAM.
The size must be equal to the full MRAM word.

@zycz
Copy link
Owner Author

zycz commented Jun 25, 2024

Changes are being added in Francesco PR: nrfconnect#15760

Please comment changes there.

@zycz zycz closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants