-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Server Infrastructure #49
Conversation
Asking Yuchen to review. Do you have instructions on how to use it? E.g., in VSCode/emacs? And we should add a LICENSE. MIT is fine with me and uncontroversial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the pull request LGTM. The infrastructure looks promising, so I'd say we accept it and build upon it.
Directly addressing these:
|
@maxsnew to run the VS Code extension during development, open To release the extension on the VS Code Marketplace, the I'm not familiar with Emacs, but there is a plugin which I believe provides very good LSP support. You would have to compile |
Nice work! We'll build our LSP on this once we figure out how to dump the type-checking results, probably after a few new features are implemented on the front end (a minimal module system, for example). Thank you for your contribution! Make any final changes you'd like, and when you feel ready, tell me to merge :) |
Should be ready to merge now. Thanks! |
Initial implementation of a language server, implementing document sync and supporting the document symbols request (in VS Code, enables the Overview pane and symbol search).
.vscode
is in the.gitignore
. However,.vscode/launch.json
and.vscode/tasks.json
are valuable for testing the language server extension. I copied my settings into.vscode-template
for now; is there a more preferred approach?/editor/code/zls
directory). Is this project intended to be closed source?