Streaming choice feature #2070
Open
Streaming choice feature #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaluma
requested changes
Sep 9, 2024
private_gpt/ui/ui.py
Outdated
| return { | ||
| True: getattr(service, f'stream_{service_type}'), | ||
| False: getattr(service, f'{service_type}') | ||
| } |
There was a problem hiding this comment.
I don't think reflection is necessary in this case. It complicates the understanding of the method a lot.
There was a problem hiding this comment.
Consider use lambda function or conventional functions and a switch statement
There was a problem hiding this comment.
My apologies on merging main after the commit
|
Can you do |
pabloogc
requested changes
Sep 23, 2024
private_gpt/ui/ui.py
Outdated
Comment on lines
101
to
102
| self._response_style = True | ||
|
|
There was a problem hiding this comment.
this variable name is very confusing, either make it explicit response_streaming = True or response_style = "streaming"
There was a problem hiding this comment.
Good point/suggestion. Changed checkbox to dropdown menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A checkbox in the UI to switch between streaming and non-streaming response output
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Notes:
Code under summarize is commented because I did not have success in employing that mode. While debugging I found that summarization would loop the output within the console and never result in output within the UI.