Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose StoreOption to c API #115

Merged
merged 1 commit into from
Aug 17, 2024
Merged

chore: expose StoreOption to c API #115

merged 1 commit into from
Aug 17, 2024

Conversation

zz-jason
Copy link
Owner

@zz-jason zz-jason commented Aug 17, 2024

What's changed and how does it work?

Ref to #97, Expose StoreOption to c API:

  • StoreOption is created by the user before creating/open a LeanStore. StoreOption's ownership is transferred to the created LeanStore if success, otherwise, users should handle the store creation error and destroy the StoreOption themselves.
  • Move all c API related include/source files to include/leanstore-c and src/leanstore-c

@zz-jason zz-jason force-pushed the jian.z/c-store-option branch 2 times, most recently from d098ac9 to adb045f Compare August 17, 2024 08:26
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 89 lines in your changes missing coverage. Please review.

Project coverage is 62.83%. Comparing base (d69d7dc) to head (bd455c8).
Report is 1 commits behind head on main.

Files Patch % Lines
src/profiling/tables/ConfigsTable.cpp 0.00% 20 Missing ⚠️
benchmarks/ycsb/YcsbLeanStore.hpp 0.00% 14 Missing ⚠️
src/profiling/tables/BMTable.cpp 0.00% 6 Missing ⚠️
benchmarks/micro-benchmarks/InsertUpdateBench.cpp 0.00% 4 Missing ⚠️
src/buffer-manager/BufferManager.cpp 82.60% 2 Missing and 2 partials ⚠️
src/buffer-manager/PageEvictor.cpp 0.00% 4 Missing ⚠️
src/concurrency/ConcurrencyControl.cpp 20.00% 0 Missing and 4 partials ⚠️
src/leanstore-c/StoreOption.cpp 82.60% 1 Missing and 3 partials ⚠️
...nstore/btree/core/PessimisticExclusiveIterator.hpp 25.00% 1 Missing and 2 partials ⚠️
...clude/leanstore/btree/core/PessimisticIterator.hpp 0.00% 0 Missing and 2 partials ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   62.75%   62.83%   +0.08%     
==========================================
  Files         119      119              
  Lines        8948     9012      +64     
  Branches     3247     3291      +44     
==========================================
+ Hits         5615     5663      +48     
- Misses       2923     2939      +16     
  Partials      410      410              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zz-jason zz-jason merged commit 1d11314 into main Aug 17, 2024
5 checks passed
@zz-jason zz-jason deleted the jian.z/c-store-option branch August 17, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant