Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use PerfCounters to replace counters & metrics #129

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

zz-jason
Copy link
Owner

@zz-jason zz-jason commented Sep 5, 2024

What's changed and how does it work?

  • records counters for each worker thread in PerfContext
  • remove old counters and metrics manager
  • remove dependency on prometheus-cpp
  • providing an example to gather counters in PerfContext

@zz-jason zz-jason force-pushed the jian.z/perf-context branch 2 times, most recently from 1b60467 to 624d2d8 Compare September 6, 2024 13:29
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.

Project coverage is 62.07%. Comparing base (925a074) to head (b802f1b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nstore/btree/core/PessimisticExclusiveIterator.hpp 40.00% 3 Missing ⚠️
src/btree/TransactionKV.cpp 60.00% 2 Missing ⚠️
src/concurrency/WorkerContext.cpp 50.00% 2 Missing ⚠️
include/leanstore/Exceptions.hpp 0.00% 1 Missing ⚠️
src/buffer-manager/PageEvictor.cpp 0.00% 1 Missing ⚠️
src/leanstore-c/leanstore-c.cpp 0.00% 1 Missing ⚠️
src/telemetry/MetricsHttpExposer.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   56.78%   62.07%   +5.29%     
==========================================
  Files          98       84      -14     
  Lines        7194     6421     -773     
  Branches     3349     2919     -430     
==========================================
- Hits         4085     3986      -99     
+ Misses       2732     2065     -667     
+ Partials      377      370       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zz-jason zz-jason changed the title chore: use PerfContext to replace counters & metrics chore: use PerfCounters to replace counters & metrics Sep 6, 2024
@zz-jason zz-jason merged commit a19fa4f into main Sep 6, 2024
7 checks passed
@zz-jason zz-jason deleted the jian.z/perf-context branch September 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant