Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Json support #791

Open
wants to merge 71 commits into
base: master
Choose a base branch
from
Open

Add Json support #791

wants to merge 71 commits into from

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Apr 8, 2024

No description provided.

@StefH StefH added the feature label Apr 8, 2024
@StefH StefH self-assigned this Apr 8, 2024
@StefH StefH mentioned this pull request Apr 8, 2024
@StefH StefH changed the title Add Json support Add Json support (WIP...) Apr 9, 2024
@paule96
Copy link

paule96 commented May 7, 2024

@StefH no not really.

every of the following lines throws the exception above:

ParameterExpression y = Expression.Parameter(typeof(JsonDocument), "y");
_ = DynamicExpressionParser.ParseLambda(new ParameterExpression[] { y }, null, "y => y.test"); 
_ = DynamicExpressionParser.ParseLambda(new ParameterExpression[] { y }, null, "y => y.test xy y.lol");
_ = DynamicExpressionParser.ParseLambda(new ParameterExpression[] { y }, null, "y => y.test != y.lol");

But I don't know if this is expected right now or if it should work. As mentioned for my code I really don't need it.

@paule96
Copy link

paule96 commented May 7, 2024

Sidenote: After working with the package for two weeks now, it feels pretty solid to me. 👍

@StefH
Copy link
Collaborator Author

StefH commented May 7, 2024

@StefH no not really.

every of the following lines throws the exception above:

ParameterExpression y = Expression.Parameter(typeof(JsonDocument), "y");
_ = DynamicExpressionParser.ParseLambda(new ParameterExpression[] { y }, null, "y => y.test"); 
_ = DynamicExpressionParser.ParseLambda(new ParameterExpression[] { y }, null, "y => y.test xy y.lol");
_ = DynamicExpressionParser.ParseLambda(new ParameterExpression[] { y }, null, "y => y.test != y.lol");

But I don't know if this is expected right now or if it should work. As mentioned for my code I really don't need it.

Now I understand.
This cannot work because the JsonDocument does not have a test property.

Only when a JsonDocument is converted to an anonymous class, then this class will have the test property defined.


A possible solution would be to create a new SystemTextJsonDynamicExpressionParser.ParseLambda , however this will not be in scope for now.

@paule96
Copy link

paule96 commented Jun 14, 2024

@StefH what is the plan to merge this branch to master? what are the open points? Can I help at any?

@StefH
Copy link
Collaborator Author

StefH commented Jun 15, 2024

@paule96
I noticed that the ThenBy does not work correct, I need to remove that logic.

Copy link

sonarcloud bot commented Jun 22, 2024

@StefH StefH changed the title Add Json support (WIP...) Add Json support Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants