Throw ArgumentException when expression has invalid compare (e.g. string with int) #851
+24
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
#if
directive inNotNullWhenAttribute.cs
to includeNETSTANDARD2_0
and removeNETSTANDARD1_3_OR_GREATER
. UpdatedGenerateStaticMethodCall
inExpressionHelper.cs
to useTryGetStaticMethod
instead ofGetStaticMethod
, throwing anArgumentException
if the method is not found. ReplacedGetStaticMethod
withTryGetStaticMethod
inExpressionHelper.cs
. AddedMyView
class with nullableProperties
dictionary toExpressionParserTests.cs
. AddedParse_InvalidExpressionShouldThrowArgumentException
test to verifyArgumentException
is thrown for invalid expressions.