Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A separate attempt at the renderers fix, and some related changes (C4-627) #1465

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

netsettler
Copy link
Collaborator

  • In Makefile
    • Implement psql-test.
    • Implement kibana-start-test.
    • Port renderers.py from cgap-portal except for small differences needed to preserve existing behavior.
    • Port test_renderers.py, too.
  • Move INDEXER_NAMESPACE_FOR_TESTING setup from conftest.py to conftest_settings.py.
  • Move ORDER from datafixtures.py to conftest_settings.py.
  • Fix static help page tests like they're fixed in cgap-portal (involving changes to page.json and static_section.json in workbook-inserts.
  • Mostly PEP8 fixes (a lot of them) in test_indexing.py, but also a minor change in how a mock is set up (via mock.patch.object instead of mock.patch).
  • PEP8 changes (a lot) in test_search.py
  • Make workbook_fixtures.py use INDEXER_NAMESPACE_FOR_TESTING.

Copy link
Member

@willronchetti willronchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants